[SPARK-27201][WebUI] Toggle full job description on click#24145
Closed
gengliangwang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-27201][WebUI] Toggle full job description on click#24145gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
wangyum
reviewed
Mar 19, 2019
core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
Outdated
Show resolved
Hide resolved
Member
|
I'm OK with that. Does it still allow you to click the link in the cell? just want to make sure it doesn't interfere with single clicks on the hyperlink. |
|
Test build #103672 has started for PR 24145 at commit |
Member
Author
|
@srowen Yes, the link still works. |
Member
|
Retest this please. |
dongjoon-hyun
approved these changes
Mar 20, 2019
Member
There was a problem hiding this comment.
+1, LGTM (Pending Jenkins). This is much nicer than before. Previously, it's only one-way (expanding only). Now, it's two-way (expand and collapse by toggle). Thanks, @gengliangwang !
dongjoon-hyun
changed the title
|
Test build #103707 has finished for PR 24145 at commit
|
Member
|
retest this please |
HyukjinKwon
approved these changes
Mar 20, 2019
|
Test build #103718 has finished for PR 24145 at commit
|
Member
|
Merged to master. |
gengliangwang
pushed a commit
that referenced
this pull request
Oct 24, 2019
### What changes were proposed in this pull request? On clicking job description in jobs page, the description was not shown fully. Add the function for the click event on description. ### Why are the changes needed? when there is a long description of a job, it cannot be seen fully in the UI. The feature was added in #24145 But it is missed after #25374 Before change:  After change: on Double click over decription  ### Does this PR introduce any user-facing change? No ### How was this patch tested? Manually test Closes #26222 from PavithraRamachandran/jobs_description_tooltip. Authored-by: Pavithra Ramachandran <pavi.rams@gmail.com> Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
PavithraRamachandran
added a commit
to PavithraRamachandran/spark
that referenced
this pull request
Oct 31, 2019
On clicking job description in jobs page, the description was not shown fully. Add the function for the click event on description. when there is a long description of a job, it cannot be seen fully in the UI. The feature was added in apache#24145 But it is missed after apache#25374 Before change:  After change: on Double click over decription  No Manually test Closes apache#26222 from PavithraRamachandran/jobs_description_tooltip. Authored-by: Pavithra Ramachandran <pavi.rams@gmail.com> Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, in #6646 there was an improvement to show full job description after double clicks.
I think this is a bit hard to be noticed by some users. I suggest changing the event to one click.
Also, after the full description is shown, another click should be able to hide the overflow text again.
Before click:
After click:
Click again:
How was this patch tested?
Manually check.